Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: stop linting with nanosvg support enabled #588

Merged

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Jul 28, 2024

  • this generate a lot of warnings with clang-tidy & cppcheck in nanosvg & stb headers
  • it does not match our default configuration on koreader anyway (where lunasvg is used)

This change is Reviewable

- this generate a lot of warnings with clang-tidy & cppcheck in
  nanosvg & stb headers
- it does not match our default configuration on koreader anyway
  (where lunasvg is used)
@poire-z poire-z merged commit e0172c1 into koreader:master Jul 28, 2024
1 check failed
@benoit-pierre benoit-pierre deleted the pr/lint_without_nanosvg_support branch July 28, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants